-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tribute contract implementation #27
Conversation
e3a7644
to
ffa7588
Compare
Co-authored-by: Philip Offtermatt <[email protected]>
Co-authored-by: Philip Offtermatt <[email protected]>
Just out of an abundance of caution, we should make sure that if a proposal receives no support at all, we allow refunding its tribute. |
We are good here with our current implementation, since the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks! LGTM
Closes #7
The three main messages are kept pretty much the same way they were, except for the part that they don't consider only the winner proposal, but the top N proposals. Round ID has been removed from AddTribute message, since it is only allowed to add tributes for the ongoing round. The code that calculates the amount of tribute that goes to each voter is adjusted to calculate percentage correctly.