Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sum-up the tokens from all lock entries before adding them to BankMsg::Send in unlock_tokens() #43

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Sum-up the tokens from all lock entries before adding them to BankMsg::Send in unlock_tokens() #43

merged 2 commits into from
Jun 28, 2024

Conversation

dusan-maksimovic
Copy link
Contributor

No description provided.

@dusan-maksimovic dusan-maksimovic self-assigned this Jun 28, 2024
p-offtermatt
p-offtermatt approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@p-offtermatt p-offtermatt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does it make sense to add a test for this, just in the contract? i.e. testing that we actually get one send out in a case where we would have had 2 before?

@dusan-maksimovic
Copy link
Contributor Author

Added test in 3c5d487

@dusan-maksimovic dusan-maksimovic merged commit 26d34d4 into main Jun 28, 2024
4 checks passed
@dusan-maksimovic dusan-maksimovic deleted the dusan/sum-tokens-on-unlock branch June 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

Assignees

@dusan-maksimovic dusan-maksimovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dusan-maksimovic @p-offtermatt