Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contract schemas json/ts generation #53

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Contract schemas json/ts generation #53

merged 2 commits into from
Jul 31, 2024

Conversation

dusan-maksimovic
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic commented Jul 31, 2024 •
edited
Loading

  • Moved schema files into src/bin so that cargo run could be run
  • Added make command to generate JSON/TS artifacts of contract messages
  • Added *Response type for each of our queries so they could be used to generate TS code used at front end

@dusan-maksimovic dusan-maksimovic self-assigned this Jul 31, 2024
MSalopek
MSalopek approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from FE perspective.
We may need some small additions to the build scripts.

@dusan-maksimovic
Copy link
Contributor Author

LGTM from FE perspective. We may need some small additions to the build scripts.

Working on it.... :)

p-offtermatt
p-offtermatt approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dusan-maksimovic dusan-maksimovic merged commit c6581a7 into main Jul 31, 2024
4 checks passed
@dusan-maksimovic dusan-maksimovic deleted the dusan/schema-changes branch July 31, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-offtermatt p-offtermatt p-offtermatt approved these changes

@MSalopek MSalopek MSalopek approved these changes

Assignees

@dusan-maksimovic dusan-maksimovic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusan-maksimovic @MSalopek @p-offtermatt