Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow whitelist admins to add new tranches #54

Merged
merged 4 commits into from
Aug 2, 2024

Conversation

dusan-maksimovic
Copy link
Contributor

@dusan-maksimovic dusan-maksimovic commented Aug 1, 2024

Closes #52

  • Changed tranches initialization- now we pass only names and IDs are assigned automatically
  • Duplicate tranche names are now forbidden
  • Added new execute message that allows whitelist admins to add new tranches

@p-offtermatt
Copy link
Member

Nice work.
Some thoughts:

  • I think we can probably do without a DeleteTranche function
  • Could we add the metadata field back to the tranches? I think it's probably important eventually, and I want to avoid a need to do hacky things like putting all data in the name field. Might also be useful to have a message to edit a tranche name and description for a given id.

Copy link
Member

@p-offtermatt p-offtermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think the validation is good. Just a nit about the response, but otherwise I think we can merge

@dusan-maksimovic dusan-maksimovic merged commit 5ce9b3f into main Aug 2, 2024
4 checks passed
@dusan-maksimovic dusan-maksimovic deleted the dusan/dynamic-tranches branch August 2, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow dynamic creation of tranches
2 participants