add tests

Signed-off-by: Bailin He <[email protected]>

.gitignore

@@ -7,3 +7,18 @@ audit.log
 identity-api
 !chart/identity-api
 
+# vscode stuff
+.vscode/*
+.vscode/settings.json
+!.vscode/tasks.json
+!.vscode/extensions.json
+!.vscode/*.code-snippets
+
+# Local History for Visual Studio Code
+.history/
+
+# Built Visual Studio Code Extensions
+*.vsix
+
+# binary files
+tmp

internal/api/httpsrv/handler_group.go

@@ -237,6 +237,15 @@ func (h *apiHandler) DeleteGroup(ctx context.Context, req DeleteGroupRequestObje
 
 	group, err := h.engine.GetGroupByID(ctx, gid)
 	if err != nil {
+		if errors.Is(err, types.ErrNotFound) {
+			err = echo.NewHTTPError(
+				http.StatusNotFound,
+				fmt.Sprintf("group %s not found", gid),
+			)
+
+			return nil, err
+		}
+
 		return nil, err
 	}