Skip to content
This repository has been archived by the owner on Dec 12, 2023. It is now read-only.

project field can now list project names #59

Closed
wants to merge 1 commit into from

Conversation

yadneshk
Copy link
Contributor

If CeilometerEnableTenantDiscovery is enabled, ceilometer samples will contain project_name field, values from which are populated in project field.

This change affects 2 dashboards, 'Cloud View' and 'Virtual Machine View', only these allow switching between openstack projects.

If samples are missing project_name field, the regex for project variable allows fallback to project field

If `CeilometerEnableTenantDiscovery` is enabled, ceilometer samples
will contain `project_name` field, values from which are populated
in `project` field.

This change affects 2 dashboards, 'Cloud View' and 'Virtual Machine View',
only these allow switching between openstack projects.

If samples are missing `project_name` field, the regex for `project`
variable allows fallback to `project` field
Copy link
Contributor

@csibbitt csibbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only thing this PR is missing is screenshots of the before, after, and after-with-the-new-option-disabled to help convince reviewers is really works.

"refId": "StandardVariableQuery"
},
"refresh": 1,
"regex": "",
"regex": "/project_name="(?<text>[^"]+)|project="(?<value>[^"]+)/g",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@leifmadsen
Copy link
Member

I'll have to pull this into my changes in STO so that we don't lose this. Going forward, dashboard changes will need to land in the service-telemetry-operator repo.

(This change showed up before that happened. I'll organize getting the changed into the appropriate spot before I mark this repo read-only so we don't have regressions.)

@leifmadsen
Copy link
Member

Closing this pull request as I've migrated it to infrawatch/service-telemetry-operator#554. Thanks Yadnesh!

@leifmadsen leifmadsen closed this Dec 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants