Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mg-master_RHOSPDOC-1200_STF-disconnected #531
mg-master_RHOSPDOC-1200_STF-disconnected #531
Changes from 2 commits
31ad58a
a12b05c
423dd99
a633a61
288d5c5
27746c0
12df359
ac288c2
347a5f4
5fc1ae7
7cd8eec
38fbf51
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is an optional step, change (Optional) to Optional. Ref: pg 202 IBM SG.
But I actually don't think that it's an optional step. If your mirror registry is not reachable, you must do one of 2 things, save and physically transfer OR run oc-mirror. So you can present the step as follows:
. If your mirror registry is not reachable, perform one of the following steps:
oc-mirror
and physically transfer them to the mirror registry and {OpenShift} cluster.oc-mirror
command and point to the mirror registry.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you want periods ending these line items, and if you do, you should do it on all lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.