Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename tasks for XML reporting #181

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Rename tasks for XML reporting #181

wants to merge 7 commits into from

Conversation

elfiesmelfie
Copy link
Collaborator

No description provided.

mgirgisf
mgirgisf reviewed Nov 28, 2024
View reviewed changes
roles/common/tasks/container_test.yml Show resolved Hide resolved
roles/telemetry_graphing/tasks/cypress_test.yml Outdated
- name: "UI-2 Run Cypress tests to validate dashboards exist"
- name: |
TEST Run Cypress tests to validate dashboards exist
UI-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UI-2

roles/telemetry_graphing/tasks/cypress_test.yml Outdated
- name: "UI-3 Check if all Cypress tests passed"
- name: |
TEST Check if all Cypress tests passed
UI-3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UI-3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leonid opened a new PR for this: #182

roles/telemetry_graphing/tasks/verify_url.yml Outdated
- name: "UI-1 Check OpenShift Console URL is accessible"
- name: |
TEST Check OpenShift Console URL is accessible
UI-1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UI-1

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 8e5e13c to 31c359f Compare November 28, 2024 19:01
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/064c53b7a9e747b488998fb84e99991c

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 58s
✔️ functional-tests-on-osp18 SUCCESS in 1h 34m 54s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 10m 03s
✔️ functional-graphing-tests-osp18 SUCCESS in 1h 11m 04s
❌ functional-metric-verification-tests-osp18 FAILURE in 1h 14m 17s

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch 2 times, most recently from 406bda7 to 6f950c0 Compare December 4, 2024 15:00
@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 6f950c0 to 0230bac Compare December 11, 2024 14:06
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/d347ecdbd95e447b951cde9a3175ebe9

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 47m 43s
✔️ functional-tests-on-osp18 SUCCESS in 1h 34m 57s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 08m 44s
❌ functional-graphing-tests-osp18 FAILURE in 1h 09m 55s
✔️ functional-metric-verification-tests-osp18 SUCCESS in 1h 11m 42s

@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 13e47ba to 903fd72 Compare December 11, 2024 19:09
@elfiesmelfie
[common] Update task names for XML reporting
6af0ccf
@elfiesmelfie
[common] Rename the test for projects
fbe5e19
@elfiesmelfie
[common] Rename the test for pods
d472c84 
Include the namespace and pod that is being checked in the name to get to the following
format for the testcase name in snake_case
  check_{{ pod_name }}_pod_is_running_in_{{ namespace }}_namespace
@elfiesmelfie
[common] Rename the test for CR status
f3f2e64
@elfiesmelfie
[ci/logging] Use include_role instead of import_role for using the co…
3f9bf78 
…mmon role

The values for the loop items don't seem to render otherwise.
@elfiesmelfie elfiesmelfie force-pushed the efoley_xml_reporting_rename branch from 903fd72 to 3f9bf78 Compare December 11, 2024 20:08
@elfiesmelfie
[ansible-lint] Update the config to ignore templates in task names
4a2342b 
name[template]: Jinja templates should only be at the end of 'name'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgirgisf mgirgisf mgirgisf left review comments

@vyzigold vyzigold Awaiting requested review from vyzigold

@ayefimov-1 ayefimov-1 Awaiting requested review from ayefimov-1

@lnatapov lnatapov Awaiting requested review from lnatapov

@myadla myadla Awaiting requested review from myadla

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elfiesmelfie @mgirgisf