Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test_alerts] Replace pause with retry/until #198

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[test_alerts] Replace pause with retry/until #198

wants to merge 3 commits into from

Conversation

elfiesmelfie
Copy link
Collaborator

  • Replace pause with a continuous check
  • Extend the wait time, to account for latency

@elfiesmelfie elfiesmelfie force-pushed the efoley_stf_fvt/test_alerts_replace_pause branch from b993999 to 821e5f1 Compare December 10, 2024 18:14
@elfiesmelfie
[test_alerts] Replace pause with retry/until
8bf95fa 
* Replace pause with a continuous check
* Extend the wait time, to account for latency
@elfiesmelfie elfiesmelfie force-pushed the efoley_stf_fvt/test_alerts_replace_pause branch from 821e5f1 to 8bf95fa Compare December 11, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myadla myadla myadla approved these changes

@lnatapov lnatapov lnatapov approved these changes

@vkmc vkmc Awaiting requested review from vkmc

@mgirgisf mgirgisf Awaiting requested review from mgirgisf

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elfiesmelfie @lnatapov @myadla