Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service and file tests to the logging job #200

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add service and file tests to the logging job #200

wants to merge 4 commits into from
+112 −1

Conversation

myadla
Copy link
Contributor

@myadla myadla commented Dec 10, 2024

OSPRH-9659

This covers adding the tasks from #123 into a spearate PR, which will include:

Update roles/common/tasks/main.yml
Add roles/common/tasks/service_tests.yml
Add roles/common/tasks/file_tests.yml
Add service_tests and file_tests to the ci/logging* playbook
Update the README file to document the configuration options

mgirgisf
mgirgisf requested changes Dec 10, 2024
View reviewed changes
roles/common/README.md Outdated Show resolved Hide resolved
myadla and others added 2 commits December 15, 2024 17:00
@myadla @elfiesmelfie
Update roles/common/tasks/service_tests.yml
bdae7ac 
Co-authored-by: Emma Foley <[email protected]>
@myadla
Update README.md
5c4bce7 
Made the suggested changes
mgirgisf
mgirgisf approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@mgirgisf mgirgisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Munesha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elfiesmelfie elfiesmelfie elfiesmelfie requested changes

@mgirgisf mgirgisf mgirgisf approved these changes

@ayefimov-1 ayefimov-1 Awaiting requested review from ayefimov-1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myadla @elfiesmelfie @mgirgisf