STF 1.5.4 release ops #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I rebased I inadvertently added an invalid reference which breaks cachito. Imports require requirements.txt to be pinned to a version. Signed-off-by: Leif Madsen <[email protected]> Signed-off-by: Leif Madsen <[email protected]>
* Clean up hadolint output Clean up hadolint output which causes failures testing in GitHub Actions. Remove unnecessary upgrades (which are reverted by requirements files) and package installation (satisfied by requirements). Resolves: STF-1256 * Syncronize versions across requirements files
* Extend available options to prometheus-webhook-snmp Related: STF-559 * Adjust Dockerfile to conform to hadolint checks * Set pip installation version * Various fixes for linting and build warnings - Complete clean up of the linting and verify everything continues to build - Clean up the Dockerfile for python package updates which were just being overridden by the requirements-built.txt * Use proper .hadolint.yaml file * Don't Dockerfile lint error on info
* Allow shell meta-characters in SNMP vars
Instead of updating the .zuul.yaml file everytime infrawatch/service-telemetry-operator adds a new job, the project-template can be updated in STO, which will propogate the change to the project and avoid leaving gaps in testing. Depends-On: http://github.com/infrawatch/service-telemetry-operator/pull/514
leifmadsen
approved these changes
Feb 8, 2024
leifmadsen
reviewed
Feb 8, 2024
It looks to me like the first 4 were previously squash+merged during the STF 1.5.1 release prep, and now they are being merged again without the squash, which produces additional history but ends up being a no-op in the code. The next 2 are the zuul additions, and the 7th is this one. It did strike me as a bit odd on first glance, but I think everything is fine. |
csibbitt
approved these changes
Feb 12, 2024
elfiesmelfie
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.