Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for not set sto and sgo bundle paths #447

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

vkmc
Copy link
Collaborator

@vkmc vkmc commented Sep 1, 2023

This change adds a check for whether sto and sgo bundle paths are defined and properly inform the user if they are undefined.

Also sets the nightly builds available in Quay as defaults.

vkmc added 2 commits September 1, 2023 14:56
This change adds a check for whether sto and sgo bundle paths
are defined and properly inform the user if they are undefined.

Also sets the nightly builds available in Quay as defaults.
Copy link
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'll rebase the efoley-add_zuul branch on top of this and see if it all passes CI.
Once that happens, we can merge this.

@elfiesmelfie
Copy link
Collaborator

elfiesmelfie commented Sep 1, 2023

I was seeing some issues with the gate, which have since been resolved.
I've rebased PR- 429 onto this branch, and we'll see the results soon.
While the job is running, you can follow the console output here:
https://review.rdoproject.org/zuul/stream/63f12f83c3324b60a54b0a33fe957795?logfile=console.log

I removed the bundle image paths from ci/deploy.yml. I expect that the job still passes, since this change takes care of that case where those values are unset.

Zuul passed for the branch that includes these changes.
https://review.rdoproject.org/zuul/buildset/3d1acad5cfdf40248eb7b387039732b9

Copy link
Collaborator

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zuul passed: https://review.rdoproject.org/zuul/buildset/3d1acad5cfdf40248eb7b387039732b9

The commits in this review are included in that passing branch.

@elfiesmelfie elfiesmelfie merged commit 6bf4784 into master Sep 4, 2023
7 checks passed
@elfiesmelfie elfiesmelfie deleted the vkmc-stf-1445 branch September 4, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants