Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Grafana management in all observability modes #449

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

leifmadsen
Copy link
Member

Allow management of Grafana in all observability modes. Grafana
continues to be installed from community operators, but can continue to
be used even when deploying STF in the default observability strategy of
use_redhat.

Closes STF-1500

Signed-off-by: Leif Madsen [email protected]

Allow management of Grafana in all observability modes. Grafana
continues to be installed from community operators, but can continue to
be used even when deploying STF in the default observability strategy of
use_redhat.

Closes STF-1500

Signed-off-by: Leif Madsen <[email protected]>
@leifmadsen leifmadsen self-assigned this Sep 6, 2023
@leifmadsen leifmadsen added needs-testing Needs a round of functional testing 1.5 labels Sep 6, 2023
@leifmadsen
Copy link
Member Author

Pretty sure this is the only change required to allow this to work. I am going to do a local build and test though just to verify everything.

@leifmadsen leifmadsen requested a review from csibbitt September 7, 2023 14:36
@leifmadsen leifmadsen marked this pull request as ready for review September 7, 2023 14:36
@leifmadsen
Copy link
Member Author

I have tested this and validated that with use_redhat you can create a Grafana instance via the existing STF CR.

One thing to note is that our default in stf-run-ci is to disable the community-operators, so if you want to test this after deploying with stf-run-ci, you need to modify the OperatorHub cluster CR in the openshift-marketplace namespace so that the Grafana Operator packagemanifest is available to the cluster for installation.

@leifmadsen leifmadsen removed the needs-testing Needs a round of functional testing label Sep 7, 2023
Copy link
Collaborator

@csibbitt csibbitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding functionality by removing code. My favorite!

@leifmadsen leifmadsen merged commit cd216c0 into master Sep 7, 2023
7 checks passed
@leifmadsen leifmadsen deleted the stf-1500/allow_grafana_mgmt_use_redhat branch September 7, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants