Add new fields to sg-core metric messages #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yadneshk
force-pushed
the
include_tenant_names
branch
4 times, most recently
from
eb1251f to
4c79806
Compare
vyzigold
approved these changes
May 4, 2023
yadneshk
changed the title
yadneshk
force-pushed
the
include_tenant_names
branch
6 times, most recently
from
d8e3c96 to
bf1d57b
Compare
yadneshk
force-pushed
the
include_tenant_names
branch
3 times, most recently
from
ddf84f6 to
1235744
Compare
With changes [1] Ceilometer is now able to include "project_name" and "user_name" fields into it's metrics. These fields are only added when ceilometer has `tenant_name_discovery` config enabled. This change amends these fields to the outgoing metric messages. Fixes: infrawatch#110 [1] https://review.opendev.org/q/topic:enhanced_metrics-stable/wallaby
Few Ceilometer meters like `cpu` & `network` have 2 name fields in their metrics, `name` and `display_name`. Use delimiter ":" to merge the values of both fields. The `name` field provides extra information about the actual resource related to the instance like `cirros:tap3a84e3fc-d9` in `network` meter and `cirros:instance-00000001` in `cpu` meter.
yadneshk
force-pushed
the
include_tenant_names
branch
from
1235744 to
debce0a
Compare
|
With these 2 commits, fields Here are a few metrics from prometheus |
|
Just FYI I don't believe the CI failure here has anything to do with the patch. I know Jaromir is looking into this, so hopefully we can get this merged sometime next week. |
|
Updated branch with latest CI refactoring in the hopes we can get this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With changes [1] Ceilometer is now able to include "project_name" and "user_name" fields into it's metrics. These fields are only added when ceilometer has
tenant_name_discoveryconfig enabled.This change amends these fields to the outgoing metric messages.
Fixes: #110
[1] https://review.opendev.org/q/topic:enhanced_metrics-stable/wallaby