-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STF 1.5.5 release ops #161
Conversation
Bump actions checkout to v4 since Node.js 16 actions are deprecated. We need to update to Node.js 20, which is included in actions/checkout@v4. Also bumped helm kind-action to v1.10.0.
Bump actions checkout to v4
Update SGO to support OCP 4.16
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/4ffb179047de4de3a647442598c28623 ❌ stf-crc-ocp_412-local_build FAILURE in 27m 52s |
recheck |
@@ -13,7 +13,7 @@ LABEL operators.operatorframework.io.metrics.mediatype.v1=metrics+v1 | |||
LABEL operators.operatorframework.io.metrics.builder=operator-sdk-v0.19.4 | |||
LABEL operators.operatorframework.io.metrics.project_layout=ansible | |||
LABEL com.redhat.delivery.operator.bundle=true | |||
LABEL com.redhat.openshift.versions="v4.12-v4.14" | |||
LABEL com.redhat.openshift.versions="v4.14-v4.16" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct?
In STO we didn't drop 4.12 in the Dockerfile https://github.com/infrawatch/service-telemetry-operator/pull/628/files#diff-1bdd52a34bf3a3abe6a623c0296503ce293c3a2c7ebdf65e8290b282d4574b9cR16
I have a hunch this is the correct version if we don't intend to support 4.12 anymore, in which case perhaps the STO one needs to change? I think it was simply expanded because we still have 4.12 testing happening and Emma expanded it to bring 4.16 online.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Yes, I think we should drop 4.12 from STO. Keeping it doesn't hurt, but we want to move from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already dropped upstream CI https://github.com/infrawatch/service-telemetry-operator/blob/master/.zuul.yaml, so I don't see a point of keeping it. I will propose a change for STO.
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/6ada2672bde644739f6bab47fb6b6aec ❌ stf-crc-ocp_412-local_build FAILURE in 27m 57s |
…le-operator Use openshift-ansible-operator 4.14 in SGO
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/615186b3c04a40dfa24eb2e22f5a21e7 ❌ stf-crc-ocp_412-local_build FAILURE in 29m 54s |
421ce6b
to
dd9da06
Compare
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/05c6039cacd646b8b56c1ee8540f12ef ❌ stf-crc-ocp_412-local_build FAILURE in 31m 15s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/aafb8a9fa61347bfa88bc973d2e5f353 ❌ stf-crc-ocp_414-local_build FAILURE in 26m 27s |
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bf04acfe7b6a4d5a9f608874e5942101 ✔️ stf-crc-ocp_414-local_build SUCCESS in 34m 31s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update this base? I just spotted it with SGO, and may have missed with STO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was updated in STO already :) infrawatch/service-telemetry-operator@27cb54a
recheck |
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/50ac90fd1aae4b16935b49dbb800f12c ✔️ stf-crc-ocp_414-local_build SUCCESS in 36m 17s |
Depends-On: infrawatch/sg-core#141