Do not set loaded booleans to readonly for perl >= v5.36 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlpunk
force-pushed
the
load-builtin-bools
branch
from
7d8022d
to
a64c273
Compare
perlpunk
force-pushed
the
load-builtin-bools
branch
3 times, most recently
from
89707fe
to
bf67fac
Compare
ingydotnet
approved these changes
Sep 7, 2024
perlpunk
force-pushed
the
load-builtin-bools
branch
from
bf67fac
to
ffe795d
Compare
perlpunk
changed the title
perlpunk
changed the title
Since perl 5.36, PL_sv_yes/PL_sv_no will be preserved as booleans automatically. If we create them with newSVsv(), they are not readonly anymore and will still roundtrip. Also add a cleanup in t/file.t
perlpunk
force-pushed
the
load-builtin-bools
branch
from
ffe795d
to
44aa92f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since perl 5.36, PL_sv_yes/PL_sv_no will be preserved as booleans
automatically. If we create them with newSVsv(), they are not readonly
anymore and will still roundtrip.