add l1 block height to output type

[sh-cha]

Summary by CodeRabbit

• New Features

  • Introduced a new data field, L1BlockNumber, in the Output structure, enhancing output data integrity.
  • Updated serialization methods to accommodate the new field, ensuring proper data handling.

• Bug Fixes

  • Modified the IsEmpty logic to include L1BlockNumber for consistency in determining empty outputs.

• Tests

  • Enhanced multiple test cases to include L1BlockNumber, improving test coverage and relevance.

• Documentation

  • Updated the data structure documentation to reflect the addition and changes of the L1BlockNumber field.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The recent changes introduce the L1BlockNumber field to the Output structure, enhancing data representation within the system. This addition impacts multiple files, including protobuf definitions, test cases, and methods, ensuring the field is integrated into existing logic and control flows. The updates improve the overall functionality and context-awareness of the Output, particularly in relation to Layer 1 blockchain interactions.

Changes

Files	Change Summary
api/opinit/ophost/v1/types.pulsar.go	Added L1BlockNumber to Output struct; updated various methods to handle the new field.
proto/opinit/ophost/v1/types.proto	Introduced l1_block_number field; adjusted identifiers for existing fields.
x/ophost/keeper/genesis_test.go	Enhanced tests to include L1BlockNumber with specific initialized values.
x/ophost/keeper/msg_server.go	Modified ProposeOutput method to populate L1BlockNumber with current block height from SDK context.
x/ophost/keeper/msg_server_test.go	Updated Test_ProposeOutput to dynamically set L1BlockNumber based on current block height.
x/ophost/keeper/output_test.go	Added L1BlockNumber to multiple test cases, establishing consistent test conditions.
x/ophost/keeper/querier_test.go	Replaced L1BlockTime with L1BlockNumber for consistency; now derives block time from context.
x/ophost/types/output.go	Altered IsEmpty method logic to check L1BlockNumber instead of L1BlockTime.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant MsgServer
    participant Output

    Client->>MsgServer: ProposeOutput()
    MsgServer->>Output: Create Output instance
    Output->>Output: Set L1BlockNumber from block height
    MsgServer-->>Client: Proposal accepted

Loading

Poem

In fields of code where rabbits play,
A number hops in bright array.
With L1BlockNumber now in sight,
The data dances, oh what a delight!
So raise your paws and give a cheer,
For changes made, we hold so dear! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.66%. Comparing base (9332e1a) to head (6649137).

Files	Patch %	Lines
x/ophost/types/output.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
+ Coverage   47.65%   47.66%   +0.01%     
==========================================
  Files          57       57              
  Lines        4203     4204       +1     
==========================================
+ Hits         2003     2004       +1     
  Misses       1782     1782              
  Partials      418      418              

Files	Coverage Δ
x/ophost/keeper/msg_server.go	57.31% <100.00%> (+0.10%)	⬆️
x/ophost/types/output.go	0.00% <0.00%> (ø)

[beer-1]

LGTM