Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo and update Validate() of BridgeConfig #25

Merged
merged 1 commit into from
Feb 26, 2024
Merged

fix typo and update Validate() of BridgeConfig #25

merged 1 commit into from
Feb 26, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Feb 13, 2024

I haven't found more reasonable thresholds for the values of BridgeConfig rather than zeros..

@Vritra4 Vritra4 requested a review from beer-1 February 13, 2024 03:36
@Vritra4 Vritra4 requested a review from a team as a code owner February 13, 2024 03:36
@Vritra4 Vritra4 self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (be17848) 57.73% compared to head (e7e014c) 57.73%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   57.73%   57.73%           
=======================================
  Files          23       23           
  Lines        1448     1448           
=======================================
  Hits          836      836           
  Misses        434      434           
  Partials      178      178           

Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 77c1e0b into main Feb 26, 2024
3 checks passed
@beer-1 beer-1 deleted the chore-fix branch February 26, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants