Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete output proposal bug #35

Merged
merged 2 commits into from
Mar 25, 2024
Merged

delete output proposal bug #35

merged 2 commits into from
Mar 25, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Mar 23, 2024

there is no check if an output proposal is finalized when deleting it

@sh-cha sh-cha requested a review from beer-1 March 23, 2024 06:47
@sh-cha sh-cha requested a review from a team as a code owner March 23, 2024 06:47
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 57.96%. Comparing base (77ca824) to head (b5f8449).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #35      +/-   ##
==========================================
- Coverage   58.19%   57.96%   -0.24%     
==========================================
  Files          23       23              
  Lines        1464     1475      +11     
==========================================
+ Hits          852      855       +3     
- Misses        434      439       +5     
- Partials      178      181       +3     
Files Coverage Δ
x/ophost/keeper/output.go 53.06% <27.27%> (-7.47%) ⬇️

Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 8e6f980 into main Mar 25, 2024
1 check passed
@beer-1 beer-1 deleted the bug/can-delete-finalized-output branch March 25, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants