Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests and minor type fixes #39

Merged
merged 21 commits into from
Apr 2, 2024
Merged

add tests and minor type fixes #39

merged 21 commits into from
Apr 2, 2024

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Apr 2, 2024

No description provided.

@beer-1 beer-1 self-assigned this Apr 2, 2024
@beer-1 beer-1 requested a review from a team as a code owner April 2, 2024 08:22
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 51.83246% with 92 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (feat/rollback@52f9434). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             feat/rollback      #39   +/-   ##
================================================
  Coverage                 ?   56.98%           
================================================
  Files                    ?       24           
  Lines                    ?     1625           
  Branches                 ?        0           
================================================
  Hits                     ?      926           
  Misses                   ?      498           
  Partials                 ?      201           
Files Coverage Δ
x/opchild/keeper/keeper.go 81.35% <100.00%> (ø)
x/opchild/keeper/msg_server.go 52.32% <100.00%> (ø)
x/opchild/keeper/val_state_change.go 52.38% <40.00%> (ø)
x/ophost/keeper/bridge.go 50.98% <0.00%> (ø)
x/ophost/keeper/querier.go 76.28% <66.66%> (ø)
x/opchild/keeper/historical_info.go 47.61% <16.66%> (ø)
x/ophost/keeper/output.go 57.74% <54.54%> (ø)
x/ophost/keeper/msg_server.go 59.16% <62.50%> (ø)
x/opchild/keeper/executor_change.go 26.31% <26.31%> (ø)

Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sh-cha sh-cha merged commit 94e5415 into feat/rollback Apr 2, 2024
3 checks passed
beer-1 added a commit that referenced this pull request Apr 3, 2024
* add opinit pulsar

* bug fix: add fee param as undefined to adjust sendtx change

* proto api update

* delete output proposal only if it is not finalized

* add ophost autocli query

* change executor's validator at end blocker according to executor change plan preset

* batch executor send last block's commit appending end of blocks bulk

* add last finalized output querier to ophost

* rpc raw commit param height

* change old executor's conspower as -1 to let comet know if executor is changed

* batch submitter to celestia send tx to celestia consensus node instead of DA light node

* delete all validators & set next executor's validator

* add batch info to bridge config

* emit and return finalized output index, l2 blocknumber when updating proposer, challenger, batchinfo

* emit finalized output event

* add tests and minor type fixes (#39)

* register denom metadata

* fix tests

* register base denom and fix claim response

* add l1 denom in resurrector

* add executor monitor start height

* bug fix: add fee param as undefined to adjust sendtx change

* delete output proposal only if it is not finalized

* add tests

* add tests and minor type fixes

* validate bridge config before update

* enforce to set batch info

* fix error message

* cleanup

---------

Co-authored-by: JSHan94 <[email protected]>
Co-authored-by: ALPAC-4 <[email protected]>
Co-authored-by: hoon <[email protected]>

* emit batch info events when creating bridge

* return err wrapper when pub key incorrectly set

* ignore api/ from codecov

---------

Co-authored-by: beer-1 <[email protected]>
Co-authored-by: JSHan94 <[email protected]>
Co-authored-by: ALPAC-4 <[email protected]>
@beer-1 beer-1 deleted the feat/rollback-audit branch April 17, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants