-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests and minor type fixes #39
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: register denom metadata
bot: register base denom
fix: add l1 denom in resurrector
feat: add executor monitor start height
delete output proposal bug
impl celestia to batch submitter
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/rollback #39 +/- ##
================================================
Coverage ? 56.98%
================================================
Files ? 24
Lines ? 1625
Branches ? 0
================================================
Hits ? 926
Misses ? 498
Partials ? 201
|
sh-cha
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
beer-1
added a commit
that referenced
this pull request
Apr 3, 2024
* add opinit pulsar * bug fix: add fee param as undefined to adjust sendtx change * proto api update * delete output proposal only if it is not finalized * add ophost autocli query * change executor's validator at end blocker according to executor change plan preset * batch executor send last block's commit appending end of blocks bulk * add last finalized output querier to ophost * rpc raw commit param height * change old executor's conspower as -1 to let comet know if executor is changed * batch submitter to celestia send tx to celestia consensus node instead of DA light node * delete all validators & set next executor's validator * add batch info to bridge config * emit and return finalized output index, l2 blocknumber when updating proposer, challenger, batchinfo * emit finalized output event * add tests and minor type fixes (#39) * register denom metadata * fix tests * register base denom and fix claim response * add l1 denom in resurrector * add executor monitor start height * bug fix: add fee param as undefined to adjust sendtx change * delete output proposal only if it is not finalized * add tests * add tests and minor type fixes * validate bridge config before update * enforce to set batch info * fix error message * cleanup --------- Co-authored-by: JSHan94 <[email protected]> Co-authored-by: ALPAC-4 <[email protected]> Co-authored-by: hoon <[email protected]> * emit batch info events when creating bridge * return err wrapper when pub key incorrectly set * ignore api/ from codecov --------- Co-authored-by: beer-1 <[email protected]> Co-authored-by: JSHan94 <[email protected]> Co-authored-by: ALPAC-4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.