Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/oracle #53

Merged
merged 15 commits into from
Apr 18, 2024
Merged

Feat/oracle #53

merged 15 commits into from
Apr 18, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Apr 16, 2024

TODO:
Due to oracle price from L1, there is no way to know the real update time on L2 side. We need to think about it.

  1. we can add timestamp on slinky's OracleVoteExtension.

@sh-cha sh-cha requested a review from beer-1 April 16, 2024 10:44
@sh-cha sh-cha requested a review from a team as a code owner April 16, 2024 10:44
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 49.40476% with 170 lines in your changes are missing coverage. Please review.

Project coverage is 50.19%. Comparing base (1af9f7e) to head (918a464).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   50.29%   50.19%   -0.11%     
==========================================
  Files          49       53       +4     
  Lines        3547     3881     +334     
==========================================
+ Hits         1784     1948     +164     
- Misses       1401     1535     +134     
- Partials      362      398      +36     
Files Coverage Δ
x/opchild/types/codec.go 100.00% <100.00%> (ø)
x/opchild/types/params.go 61.36% <100.00%> (+1.83%) ⬆️
x/opchild/keeper/keeper.go 82.27% <85.00%> (+0.61%) ⬆️
x/opchild/keeper/params.go 51.61% <50.00%> (-0.39%) ⬇️
x/opchild/l2slinky/aggregator.go 66.66% <66.66%> (ø)
x/opchild/types/tx.go 54.94% <0.00%> (-4.58%) ⬇️
x/opchild/keeper/msg_server.go 53.17% <0.00%> (-2.71%) ⬇️
x/opchild/client/cli/tx.go 59.04% <0.00%> (-5.75%) ⬇️
x/opchild/keeper/host_validator_store.go 66.66% <66.66%> (ø)
x/opchild/keeper/oracle.go 59.09% <59.09%> (ø)
... and 1 more

Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sh-cha sh-cha merged commit 8569763 into main Apr 18, 2024
4 of 5 checks passed
@sh-cha sh-cha deleted the feat/oracle branch April 18, 2024 09:31
@sh-cha sh-cha self-assigned this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants