Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable to update l1 client id only when existing is empty #61

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Apr 26, 2024

No description provided.

@sh-cha sh-cha requested a review from a team as a code owner April 26, 2024 05:08
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.78%. Comparing base (d02cd19) to head (f960d0d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   50.78%   50.78%           
=======================================
  Files          54       54           
  Lines        3989     3989           
=======================================
  Hits         2026     2026           
  Misses       1547     1547           
  Partials      416      416           
Files Coverage Δ
x/opchild/keeper/msg_server.go 57.60% <100.00%> (ø)

@JSHan94
Copy link
Collaborator

JSHan94 commented Apr 26, 2024

LGTM

@JSHan94 JSHan94 merged commit 344bb22 into main Apr 26, 2024
5 checks passed
@beer-1 beer-1 deleted the feat/update-l1clientid-only-emptystring branch May 23, 2024 05:50
@sh-cha sh-cha self-assigned this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants