Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/only withdraw tokens from l1 #76

Merged
merged 4 commits into from
May 23, 2024
Merged

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented May 21, 2024

No description provided.

@sh-cha sh-cha self-assigned this May 21, 2024
@sh-cha sh-cha requested a review from a team as a code owner May 21, 2024 08:58
Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 50.64%. Comparing base (fa4d466) to head (33097d9).
Report is 1 commits behind head on main.

Current head 33097d9 differs from pull request most recent head fc82b98

Please upload reports for the commit fc82b98 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   50.74%   50.64%   -0.10%     
==========================================
  Files          57       57              
  Lines        4158     4180      +22     
==========================================
+ Hits         2110     2117       +7     
- Misses       1605     1615      +10     
- Partials      443      448       +5     
Files Coverage Δ
x/opchild/keeper/keeper.go 73.46% <14.28%> (-4.56%) ⬇️
x/opchild/keeper/msg_server.go 56.16% <25.00%> (-1.06%) ⬇️

... and 1 file with indirect coverage changes

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 0e5d5a1 into main May 23, 2024
3 checks passed
@beer-1 beer-1 deleted the fix/only-withdrawal-tokens-from-l1 branch May 23, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants