feat: support multi challenger & fix launch cmd bug #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 51.01% 51.20% +0.18%
==========================================
Files 57 57
Lines 4203 4250 +47
==========================================
+ Hits 2144 2176 +32
- Misses 1611 1623 +12
- Partials 448 451 +3
|
djm07073
changed the title
djm07073
commented
Jun 21, 2024
Comment on lines
+4
to
+17
| // NOTE: it is a modified BridgeConfig from x/ophost/types/types.go to make unmarshal easier | ||
| type BridgeCliConfig struct { | ||
| Challenger string `json:"challenger"` | ||
| Proposer string `json:"proposer"` | ||
| SubmissionInterval string `json:"submission_interval"` | ||
| FinalizationPeriod string `json:"finalization_period"` | ||
| SubmissionStartTime string `json:"submission_start_time"` | ||
| Metadata string `json:"metadata"` | ||
| BatchInfo BatchCliInfo `json:"batch_info"` | ||
| } | ||
|
|
||
| type BatchCliInfo struct { | ||
| Submitter string `json:"submitter"` | ||
| Chain string `json:"chain"` |
- for preventing duplicated submit
djm07073
force-pushed
the
fix/multi-challenger
branch
from
599c577 to
6761b92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support multiple challengers and submitters. However, during initial bridge creation, only one challenger and submitter must be configured