Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add block height arg to NewMsgFinalizeTokenDeposit #88

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Jul 1, 2024

No description provided.

@sh-cha sh-cha self-assigned this Jul 1, 2024
@sh-cha sh-cha requested a review from a team as a code owner July 1, 2024 02:39
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 51.23%. Comparing base (a4b8921) to head (9e96e27).

Current head 9e96e27 differs from pull request most recent head 45cd857

Please upload reports for the commit 45cd857 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #88      +/-   ##
==========================================
- Coverage   51.28%   51.23%   -0.05%     
==========================================
  Files          57       57              
  Lines        4272     4280       +8     
==========================================
+ Hits         2191     2193       +2     
- Misses       1627     1631       +4     
- Partials      454      456       +2     
Files Coverage Δ
x/opchild/client/cli/tx.go 58.30% <100.00%> (-0.44%) ⬇️
x/opchild/types/tx.go 58.60% <25.00%> (-0.74%) ⬇️

x/opchild/types/errors.go Outdated Show resolved Hide resolved
Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except error message.

@sh-cha sh-cha merged commit 6c6b398 into main Jul 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants