Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change output root spec #99

Merged
merged 2 commits into from
Jul 13, 2024
Merged

change output root spec #99

merged 2 commits into from
Jul 13, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Jul 12, 2024

  • one byte version, removing state_root

@sh-cha sh-cha self-assigned this Jul 12, 2024
@sh-cha sh-cha requested a review from a team as a code owner July 12, 2024 08:32
@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 51.31%. Comparing base (1ab31b7) to head (3a8dc50).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   51.33%   51.31%   -0.02%     
==========================================
  Files          59       59              
  Lines        4414     4404      -10     
==========================================
- Hits         2266     2260       -6     
+ Misses       1680     1678       -2     
+ Partials      468      466       -2
Files Coverage Δ
x/ophost/client/cli/tx.go 60.69% <ø> (+0.32%) ⬆️
x/ophost/keeper/msg_server.go 57.84% <100.00%> (ø)
x/ophost/types/output.go 80.85% <100.00%> (-4.57%) ⬇️
x/ophost/types/tx.go 52.21% <0.00%> (+0.47%) ⬆️

beer-1
beer-1 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added minor comments.

x/ophost/client/cli/tx_test.go Show resolved Hide resolved
x/ophost/types/output.go Show resolved Hide resolved
@sh-cha sh-cha merged commit e4dc6f9 into main Jul 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beer-1 beer-1 beer-1 approved these changes

Assignees

@sh-cha sh-cha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sh-cha @beer-1