Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update slinky => connect/v2 #269

Merged
merged 5 commits into from
Sep 25, 2024
Merged

feat: update slinky => connect/v2 #269

merged 5 commits into from
Sep 25, 2024

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented Sep 24, 2024

Description

Need to wait initia-labs/OPinit#109

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 self-assigned this Sep 24, 2024
@beer-1 beer-1 requested a review from a team as a code owner September 24, 2024 09:13
Copy link

coderabbitai bot commented Sep 24, 2024

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The changes involve a comprehensive update across multiple files in the codebase, primarily focusing on transitioning from the "slinky" package to the "connect" package. This includes modifications to import paths, variable names, and comments to reflect the new library structure. Additionally, the GitHub Actions workflow file has been updated to use a newer version of the golangci-lint tool.

Changes

Files Change Summary
.github/workflows/lint.yml Updated environment variable GOLANGCI_LINT_VERSION from v1.59.1 to v1.61.0.
app/app.go, app/connect.go, app/genesis.go, app/encoding.go, app/genesis_markets/utils.go, app/keepers/keepers.go, app/keepers/keys.go, app/modules.go, app/test_helpers.go, cmd/initiad/config.go, cmd/initiad/root.go, x/bank/keeper/common_test.go, x/ibc/testing/app.go, x/move/ante/ante_test.go, x/move/keeper/api.go, x/move/keeper/api_test.go, x/move/keeper/common_test.go, x/move/types/expected_keeper.go Updated import paths from slinky to connect, along with changes in variable names and comments to reflect the new naming conventions.
scripts/protoc-swagger-gen.sh Replaced SLINKY_URL with CONNECT_URL, added CONNECT_V, and updated cloning commands to point to the connect repository.

Possibly related PRs

  • feat: add vesting vote #234: Involves modifications to app/app.go and app/keepers/keepers.go, related to governance module updates.
  • fix: audit fix #245: Changes in x/move/ante/fee.go and x/move/keeper/dex.go, potentially impacting fee calculation logic.
  • fix: audit #253: Modifications to x/distribution/keeper/allocation.go and x/move/ante/fee.go, focusing on token allocation and fee calculation robustness.

Suggested reviewers

  • sh-cha

Poem

In fields of code, we hop and play,
From "slinky" to "connect," we leap today.
With imports fresh and paths anew,
Our codebase shines, a vibrant view.
So here’s to changes, big and small,
A rabbit's cheer for one and all! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Sep 24, 2024

Dependency Review

The following issues were found:

  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 15 package(s) with unknown licenses.

View full job summary

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.66%. Comparing base (973f949) to head (4fc5b6f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
app/connect.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #269   +/-   ##
=======================================
  Coverage   40.66%   40.66%           
=======================================
  Files         264      264           
  Lines       25292    25292           
=======================================
  Hits        10286    10286           
  Misses      13411    13411           
  Partials     1595     1595           
Files with missing lines Coverage Δ
app/app.go 60.18% <100.00%> (ø)
app/encoding.go 23.52% <ø> (ø)
app/genesis.go 94.87% <100.00%> (ø)
app/genesis_markets/utils.go 84.21% <ø> (ø)
app/keepers/keepers.go 98.43% <ø> (ø)
app/keepers/keys.go 87.87% <ø> (ø)
app/modules.go 100.00% <100.00%> (ø)
x/move/keeper/api.go 67.02% <100.00%> (ø)
app/connect.go 86.84% <0.00%> (ø)

@beer-1 beer-1 merged commit 624ce30 into main Sep 25, 2024
8 of 9 checks passed
@beer-1 beer-1 deleted the feat/connect-v2 branch September 25, 2024 07:31
@coderabbitai coderabbitai bot mentioned this pull request Oct 24, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant