Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce vmpool to make each vm run on single thread #272

Merged
merged 4 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions x/move/keeper/genesis.go
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,13 @@ func (k Keeper) Initialize(
_allowedPublishers[i] = addr
}

// The default upgrade policy is compatible when it's not set,
// so skip the registration at initialize.
// TODO - remove this after loader v2 is installed
vm := k.acquireVM(ctx)
defer k.releaseVM()

// The default upgrade policy is compatible when it's not set.
vmStore := types.NewVMStore(ctx, k.VMStore)
execRes, err := k.moveVM.Initialize(vmStore, api, env, vmtypes.NewModuleBundle(modules...), _allowedPublishers)
execRes, err := vm.Initialize(vmStore, api, env, vmtypes.NewModuleBundle(modules...), _allowedPublishers)
if err != nil {
return err
}
Expand Down
18 changes: 15 additions & 3 deletions x/move/keeper/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,10 @@ func (k Keeper) executeEntryFunction(
args [][]byte,
isJSON bool,
) error {
// TODO - remove this after loader v2 is installed
vm := k.acquireVM(ctx)
defer k.releaseVM()

payload, err := types.BuildExecuteEntryFunctionPayload(
moduleAddr,
moduleName,
Expand Down Expand Up @@ -200,7 +204,7 @@ func (k Keeper) executeEntryFunction(

// run vm
gasBalance := gasForRuntime
execRes, err := k.moveVM.ExecuteEntryFunction(
execRes, err := vm.ExecuteEntryFunction(
&gasBalance,
types.NewVMStore(sdkCtx, k.VMStore),
NewApi(k, sdkCtx),
Expand Down Expand Up @@ -280,6 +284,10 @@ func (k Keeper) executeScript(
args [][]byte,
isJSON bool,
) error {
// TODO - remove this after loader v2 is installed
vm := k.acquireVM(ctx)
defer k.releaseVM()

// prepare payload
payload, err := types.BuildExecuteScriptPayload(
byteCodes,
Expand Down Expand Up @@ -315,7 +323,7 @@ func (k Keeper) executeScript(

// run vm
gasBalance := gasForRuntime
execRes, err := k.moveVM.ExecuteScript(
execRes, err := vm.ExecuteScript(
&gasBalance,
types.NewVMStore(sdkCtx, k.VMStore),
NewApi(k, sdkCtx),
Expand Down Expand Up @@ -557,6 +565,10 @@ func (k Keeper) executeViewFunction(
args [][]byte,
isJSON bool,
) (vmtypes.ViewOutput, uint64, error) {
// TODO - remove this after loader v2 is installed
vm := k.acquireVM(ctx)
defer k.releaseVM()

payload, err := types.BuildExecuteViewFunctionPayload(
moduleAddr,
moduleName,
Expand Down Expand Up @@ -586,7 +598,7 @@ func (k Keeper) executeViewFunction(
gasForRuntime := gasMeter.Limit() - gasMeter.GasConsumedToLimit()

gasBalance := gasForRuntime
viewRes, err := k.moveVM.ExecuteViewFunction(
viewRes, err := vm.ExecuteViewFunction(
&gasBalance,
types.NewVMStore(ctx, k.VMStore),
api,
Expand Down
31 changes: 22 additions & 9 deletions x/move/keeper/keeper.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import (
"context"
"errors"

"golang.org/x/sync/semaphore"

"cosmossdk.io/collections"
"cosmossdk.io/core/address"
corestoretypes "cosmossdk.io/core/store"
Expand Down Expand Up @@ -41,8 +43,10 @@ type Keeper struct {

config moveconfig.MoveConfig

// moveVM instance
moveVM types.VMEngine
// TODO - remove after loader v2
moveVMs []types.VMEngine
moveVMIdx *uint64
moveVMSemaphore *semaphore.Weighted

feeCollector string
authority string
Expand Down Expand Up @@ -85,12 +89,19 @@ func NewKeeper(
moveConfig.ContractSimulationGasLimit = moveconfig.DefaultContractSimulationGasLimit
}

moveVM, err := vm.NewVM(vmtypes.InitiaVMConfig{
// TODO: check this before mainnet
AllowUnstable: true,
})
if err != nil {
panic(err)
vmCount := 10
beer-1 marked this conversation as resolved.
Show resolved Hide resolved
moveVMIdx := uint64(0)
vms := make([]types.VMEngine, vmCount)
for i := 0; i < vmCount; i++ {
moveVM, err := vm.NewVM(vmtypes.InitiaVMConfig{
// TODO: check this before mainnet
AllowUnstable: true,
})
if err != nil {
panic(err)
}

vms[i] = &moveVM
beer-1 marked this conversation as resolved.
Show resolved Hide resolved
}

sb := collections.NewSchemaBuilder(storeService)
Expand All @@ -103,7 +114,9 @@ func NewKeeper(
msgRouter: msgRouter,
grpcRouter: grpcRouter,
config: moveConfig,
moveVM: &moveVM,
moveVMs: vms,
moveVMIdx: &moveVMIdx,
moveVMSemaphore: semaphore.NewWeighted(int64(vmCount)),
distrKeeper: distrKeeper,
StakingKeeper: stakingKeeper,
RewardKeeper: rewardKeeper,
Expand Down
24 changes: 24 additions & 0 deletions x/move/keeper/vmpool.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package keeper

import (
"context"
"sync/atomic"

"github.com/initia-labs/initia/x/move/types"
)

func (k Keeper) acquireVM(ctx context.Context) (vm types.VMEngine) {
err := k.moveVMSemaphore.Acquire(ctx, 1)
if err != nil {
panic(err)
}

idx := atomic.AddUint64(k.moveVMIdx, 1)
vm = k.moveVMs[idx%uint64(len(k.moveVMs))]

return
}

func (k Keeper) releaseVM() {
k.moveVMSemaphore.Release(1)
}
Loading