Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move-cli bugs #7

Merged
merged 5 commits into from
Nov 6, 2023
Merged

fix: move-cli bugs #7

merged 5 commits into from
Nov 6, 2023

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Nov 2, 2023

  1. make initiad q move resource accept struct tag as second parameter, instead of denom which is not appropriate.
  2. make initiad q move execute accept string with double quotation mark. ex) string:"hello world"
  3. add initiad q move params

@Vritra4 Vritra4 added the bug Something isn't working label Nov 2, 2023
@Vritra4 Vritra4 requested review from beer-1 and a team November 2, 2023 11:42
@Vritra4 Vritra4 self-assigned this Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #7 (c3bdaec) into main (3d35e9d) will increase coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   46.88%   46.92%   +0.04%     
==========================================
  Files         148      148              
  Lines       14522    14547      +25     
==========================================
+ Hits         6808     6826      +18     
- Misses       6954     6958       +4     
- Partials      760      763       +3     

see 1 file with indirect coverage changes

@Vritra4
Copy link
Contributor Author

Vritra4 commented Nov 2, 2023

shoud we support other types? like vector
and should we unquote inner string?

@Vritra4 Vritra4 changed the title [fix] move-cli bugs fix: move-cli bugs Nov 3, 2023
Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vritra4 Vritra4 merged commit b50bd7a into main Nov 6, 2023
7 checks passed
@Vritra4 Vritra4 deleted the fix/move-cli branch November 6, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants