use defer to close chan

initia-labs · Nov 27, 2024 · 3364153 · 3364153
1 parent 7f81b42
commit 3364153
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/indexer/abci_test.go b/indexer/abci_test.go
@@ -68,7 +68,9 @@ func Test_ListenFinalizeBlock_Subscribe(t *testing.T) {
 	defer app.Close()
 
 	blockChan, logsChan, pendChan := indexer.Subscribe()
-	close(pendChan)
+	defer close(blockChan)
+	defer close(logsChan)
+	defer close(pendChan)
 
 	tx, evmTxHash := tests.GenerateCreateERC20Tx(t, app, privKeys[0])
 

diff --git a/indexer/mempool_test.go b/indexer/mempool_test.go
@@ -17,8 +17,9 @@ func Test_Mempool_Subscribe(t *testing.T) {
 	defer app.Close()
 
 	blockChan, logsChan, pendChan := indexer.Subscribe()
-	close(blockChan)
-	close(logsChan)
+	defer close(blockChan)
+	defer close(logsChan)
+	defer close(pendChan)
 
 	tx, evmTxHash := tests.GenerateCreateERC20Tx(t, app, privKeys[0])