-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
bump opinit and cleanup github actions (#43)
- Loading branch information
Showing
15 changed files
with
214 additions
and
179 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,38 +1,24 @@ | ||
| --- | ||
| name: Bug report | ||
| about: Create a report to help us improve (use this for suspected bugs only, if not sure, open a regular issue below) | ||
| title: '' | ||
| labels: Bug | ||
| assignees: '' | ||
| about: Create a report to help us improve | ||
| title: "" | ||
| labels: "" | ||
| assignees: "" | ||
| --- | ||
|
|
||
| <!-- This issue tracker is only for technical issues related to Initia. | ||
| **Describe the bug** | ||
| A clear and concise description of what the bug is. | ||
|
|
||
| General initia questions and/or support requests are best directed to the initia support team. | ||
| **To Reproduce** | ||
| Steps to reproduce the behavior: | ||
|
|
||
| --> | ||
|
|
||
| <!-- Describe the issue --> | ||
| 1. Go to '...' | ||
| 2. Click on '....' | ||
| 3. Scroll down to '....' | ||
| 4. See error | ||
|
|
||
| **Expected behavior** | ||
| A clear and concise description of what you expected to happen. | ||
|
|
||
| <!--- What behavior did you expect? Describe what the software should do in response to a specific action or command.--> | ||
|
|
||
| **Actual behavior** | ||
|
|
||
| <!--- What did the software actually do when you performed the action or command? If you're unsure whether the issue is related to Initia, feel free to ask us for clarification." | ||
| --> | ||
|
|
||
| **To reproduce** | ||
|
|
||
| <!--- How reliably can you reproduce the issue, what are the steps to do so? --> | ||
|
|
||
| **System information** | ||
|
|
||
| <!-- What version of initia are you using, where did you get it (website, self-compiled, etc)? --> | ||
|
|
||
| <!-- What type of machine are you observing the error on (OS/CPU and disk type)? --> | ||
|
|
||
| <!-- initia-related issue? What is your operating system and its version? If Linux, what is your desktop environment and graphical shell? --> | ||
|
|
||
| <!-- Any extra information that might be useful in the debugging process. --> | ||
| **Additional context** | ||
| Add any other context about the problem here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,19 @@ | ||
| --- | ||
| name: Feature request | ||
| about: Suggest an idea for this project | ||
| title: '' | ||
| labels: Feature | ||
| assignees: '' | ||
|
|
||
| title: "" | ||
| labels: "" | ||
| assignees: "" | ||
| --- | ||
|
|
||
| **Is your feature request related to a problem? Please describe.** | ||
| <!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] --> | ||
| A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||
|
|
||
| **Describe the solution you'd like** | ||
| <!-- A clear and concise description of what you want to happen. --> | ||
| A clear and concise description of what you want to happen. | ||
|
|
||
| **Describe alternatives you've considered** | ||
| <!-- A clear and concise description of any alternative solutions or features you've considered. --> | ||
| A clear and concise description of any alternative solutions or features you've considered. | ||
|
|
||
| **Additional context** | ||
| <!-- Add any other context or screenshots about the feature request here. --> | ||
| Add any other context or screenshots about the feature request here. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,32 +1,46 @@ | ||
| <!-- | ||
| *** Please remove the following help text before submitting: *** | ||
| Pull requests without a rationale and clear improvement may be closed | ||
| immediately. | ||
| --> | ||
|
|
||
| <!-- | ||
| Please provide clear motivation for your patch and explain how it improves | ||
| initia user experience or initia developer experience | ||
| significantly: | ||
| * Any test improvements or new tests that improve coverage are always welcome. | ||
| * All other changes should have accompanying unit tests (see `src/test/`) or | ||
| functional tests (see `test/`). Contributors should note which tests cover | ||
| modified code. If no tests exist for a region of modified code, new tests | ||
| should accompany the change. | ||
| * Bug fixes are most welcome when they come with steps to reproduce or an | ||
| explanation of the potential issue as well as reasoning for the way the bug | ||
| was fixed. | ||
| * Features are welcome, but might be rejected due to design or scope issues. | ||
| If a feature is based on a lot of dependencies, contributors should first | ||
| consider building the system outside of initia, if possible. | ||
| --> | ||
|
|
||
| <!-- | ||
| Initia has a thorough review process and even the most trivial change | ||
| needs to pass a lot of eyes and requires non-zero or even substantial time | ||
| effort to review. There is a huge lack of active reviewers on the project, so | ||
| patches often sit for a long time. | ||
| --> | ||
| # Description | ||
|
|
||
| Closes: #XXXX | ||
|
|
||
| <!-- Add a description of the changes that this PR introduces and the files that | ||
| are the most critical to review. --> | ||
|
|
||
| --- | ||
|
|
||
| ## Author Checklist | ||
|
|
||
| _All items are required. Please add a note to the item if the item is not applicable and | ||
| please add links to any relevant follow up issues._ | ||
|
|
||
| I have... | ||
|
|
||
| - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title, you can find examples of the prefixes below: | ||
| <!-- * `feat`: A new feature | ||
| * `fix`: A bug fix | ||
| * `docs`: Documentation only changes | ||
| * `style`: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) | ||
| * `refactor`: A code change that neither fixes a bug nor adds a feature | ||
| * `perf`: A code change that improves performance | ||
| * `test`: Adding missing tests or correcting existing tests | ||
| * `build`: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) | ||
| * `ci`: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) | ||
| * `chore`: Other changes that don't modify src or test files | ||
| * `revert`: Reverts a previous commit --> | ||
| - [ ] confirmed `!` in the type prefix if API or client breaking change | ||
| - [ ] targeted the correct branch | ||
| - [ ] provided a link to the relevant issue or specification | ||
| - [ ] reviewed "Files changed" and left comments if necessary | ||
| - [ ] included the necessary unit and integration tests | ||
| - [ ] updated the relevant documentation or specification, including comments for [documenting Go code](https://blog.golang.org/godoc) | ||
| - [ ] confirmed all CI checks have passed | ||
|
|
||
| ## Reviewers Checklist | ||
|
|
||
| _All items are required. Please add a note if the item is not applicable and please add | ||
| your handle next to the items reviewed if you only reviewed selected items._ | ||
|
|
||
| I have... | ||
|
|
||
| - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title | ||
| - [ ] confirmed all author checklist items have been addressed | ||
| - [ ] reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,9 +23,6 @@ concurrency: | |
| jobs: | ||
| golangci: | ||
| env: | ||
| # for private repo access | ||
| GOPRIVATE: github.com/initia-labs | ||
| GITHUB_ACCESS_TOKEN: ${{ secrets.GH_READ_TOKEN }} | ||
| GOLANGCI_LINT_VERSION: v1.59.1 | ||
| name: golangci-lint | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -42,15 +39,15 @@ jobs: | |
| **/**.go | ||
| go.mod | ||
| go.sum | ||
| # for private repo access | ||
| - run: git config --global url.https://${GITHUB_ACCESS_TOKEN}:[email protected]/.insteadOf https://github.com/ | ||
| # install golangci-lint | ||
| - run: go install github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANGCI_LINT_VERSION} | ||
| - name: run go linters (long) | ||
| if: env.GIT_DIFF | ||
| id: lint_long | ||
| run: | | ||
| make lint | ||
| env: | ||
| GIT_DIFF: ${{ env.GIT_DIFF }} | ||
| - uses: technote-space/[email protected] | ||
| if: steps.lint_long.outcome == 'skipped' | ||
| with: | ||
|
|
@@ -68,10 +65,6 @@ jobs: | |
| # Use --check or --exit-code when available (Go 1.19?) | ||
| # https://github.com/golang/go/issues/27005 | ||
| tidy: | ||
| env: | ||
| # for private repo access | ||
| GOPRIVATE: github.com/initia-labs,github.com/skip-mev/slinky | ||
| GITHUB_ACCESS_TOKEN: ${{ secrets.GH_READ_TOKEN }} | ||
| runs-on: ubuntu-latest | ||
| name: tidy | ||
| steps: | ||
|
|
@@ -81,8 +74,6 @@ jobs: | |
| with: | ||
| go-version: 1.22 | ||
| check-latest: true | ||
| # for private repo access | ||
| - run: git config --global url.https://${GITHUB_ACCESS_TOKEN}:[email protected]/.insteadOf https://github.com/ | ||
| - run: | | ||
| go mod tidy | ||
| CHANGES_IN_REPO=$(git status --porcelain) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,9 +22,6 @@ jobs: | |
| test-coverage-upload: | ||
| name: Run test and upload codecov | ||
| env: | ||
| # for private repo access | ||
| GOPRIVATE: github.com/initia-labs/* | ||
| GITHUB_ACCESS_TOKEN: ${{ secrets.GH_READ_TOKEN }} | ||
| CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }} | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
|
|
@@ -40,15 +37,15 @@ jobs: | |
| **/**.go | ||
| go.mod | ||
| go.sum | ||
| # for private repo access | ||
| - run: git config --global url.https://${GITHUB_ACCESS_TOKEN}:[email protected]/.insteadOf https://github.com/ | ||
| - name: build | ||
| run: | | ||
| make build | ||
| - name: test & coverage report creation | ||
| run: | | ||
| go test ./... -mod=readonly -timeout 12m -race -coverprofile=coverage.txt -covermode=atomic -tags='ledger test_ledger_mock' | ||
| if: env.GIT_DIFF | ||
| env: | ||
| GIT_DIFF: ${{ env.GIT_DIFF }} | ||
| # - name: filter out DONTCOVER | ||
| # run: | | ||
| # excludelist="$(find ./ -type f -name '*.go' | xargs grep -l 'DONTCOVER')" | ||
|
|
@@ -65,3 +62,5 @@ jobs: | |
| files: ./coverage.txt | ||
| fail_ci_if_error: true | ||
| if: env.GIT_DIFF | ||
| env: | ||
| GIT_DIFF: ${{ env.GIT_DIFF }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.