Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing opchild ante #113

Merged
merged 2 commits into from
Nov 15, 2024
Merged

feat: add missing opchild ante #113

merged 2 commits into from
Nov 15, 2024

Conversation

beer-1
Copy link
Collaborator

@beer-1 beer-1 commented Nov 15, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced error handling in transaction processing to ensure all necessary components are initialized.
    • Integration of the OPChild keeper into the transaction processing flow.
  • Bug Fixes

    • Updated dependency versions to address security vulnerabilities and improve compatibility.
  • Chores

    • Updated Go toolchain and various module dependencies to their latest versions for better performance and security.

@beer-1 beer-1 requested a review from a team as a code owner November 15, 2024 08:58
Copy link

coderabbitai bot commented Nov 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily focus on modifying the HandlerOptions struct and the NewAnteHandler function within the ante.go file, updating the types of OPChildKeeper and AuctionKeeper to pointers of their respective keeper types. Additionally, error checks were added to ensure necessary components are not nil. The setupBlockSDK function in blocksdk.go was adjusted to pass the AuctionKeeper as a pointer. The go.mod files were updated to reflect new dependency versions, including the Go toolchain and specific modules.

Changes

File Change Summary
app/ante/ante.go Updated HandlerOptions struct: changed OPChildKeeper and AuctionKeeper to pointer types. Added error checks in NewAnteHandler for IBCkeeper, OPChildKeeper, and AuctionKeeper. Updated ante decorators to include opchildante.NewRedundantBridgeDecorator(options.OPChildKeeper).
app/blocksdk.go Modified setupBlockSDK function to pass AuctionKeeper as a pointer instead of dereferencing it.
go.mod Updated Go toolchain version from 1.22.7 to 1.23.0. Updated github.com/initia-labs/OPinit and api modules from v0.5.7 to v0.6.0.
integration-tests/go.mod Updated Go version from 1.22.7 to 1.23.0. Removed indirect dependencies for OPinit and api, both updated to v0.6.0.

Possibly related PRs

  • fix: do not use posthandler to handle failed tx sequence increment #92: The changes in this PR also involve modifications to the ante.go file, specifically related to the handling of decorators in the NewAnteHandler function, which is closely related to the updates made in the main PR regarding the NewAnteHandler function and the integration of the AuctionKeeper.

Suggested reviewers

  • Vritra4

Poem

🐰 In the meadow where changes bloom,
Ante handlers dance, dispelling gloom.
Pointers now guide the way with grace,
Auction keepers join the race.
With each update, we hop and cheer,
A brighter future is drawing near! 🌼

Warning

Rate limit exceeded

@beer-1 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 3 minutes and 9 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between fe8cbe5 and be14a97.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes missing coverage. Please review.

Project coverage is 28.16%. Comparing base (fe8cbe5) to head (be14a97).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/ante/ante.go 10.00% 6 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #113      +/-   ##
==========================================
- Coverage   28.17%   28.16%   -0.02%     
==========================================
  Files         126      126              
  Lines       14275    14285      +10     
==========================================
+ Hits         4022     4023       +1     
- Misses       9680     9686       +6     
- Partials      573      576       +3     
Files with missing lines Coverage Δ
app/blocksdk.go 94.54% <100.00%> (ø)
app/ante/ante.go 55.71% <10.00%> (-7.62%) ⬇️

@beer-1 beer-1 merged commit f07f8ac into main Nov 15, 2024
8 of 9 checks passed
@beer-1 beer-1 deleted the fix/add-missing-ante branch November 15, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants