Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional custom erc20 support #13

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

beer-1
Copy link
Member

@beer-1 beer-1 commented May 7, 2024

there is new params

  • allow_custom_erc20
  • alllowed_custom_erc20s

If allow_custom_erc20 is set to false, only ERC20 tokens created through the factory will be supported. If it's true, all custom ERC20 tokens are allowed by default. However, if you want to limit this to specific custom ERC20 tokens, you need to list them in allowed_custom_erc20s.

@beer-1 beer-1 requested a review from sh-cha May 7, 2024 05:48
@beer-1 beer-1 self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 7.61773% with 667 lines in your changes are missing coverage. Please review.

Project coverage is 31.14%. Comparing base (b3c7369) to head (8cebacf).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   33.41%   31.14%   -2.27%     
==========================================
  Files          66       68       +2     
  Lines        7449     8158     +709     
==========================================
+ Hits         2489     2541      +52     
- Misses       4628     5272     +644     
- Partials      332      345      +13     
Files Coverage Δ
x/evm/contracts/erc20/ERC20.go 0.00% <ø> (ø)
x/evm/contracts/erc20_registry/ERC20Registry.go 0.00% <ø> (ø)
x/evm/types/params.go 76.19% <100.00%> (+76.19%) ⬆️
x/evm/types/collection.go 0.00% <0.00%> (ø)
x/evm/keeper/erc20.go 43.06% <86.95%> (-0.22%) ⬇️
x/evm/types/address.go 55.00% <55.55%> (+55.00%) ⬆️
x/evm/contracts/i_erc20_registry/IERC20Registry.go 0.00% <0.00%> (ø)
x/evm/precompiles/erc20_registry/contract.go 51.25% <53.84%> (+0.50%) ⬆️
x/evm/keeper/genesis.go 60.00% <26.66%> (-6.67%) ⬇️
x/evm/keeper/erc20_stores.go 53.65% <44.00%> (-16.93%) ⬇️
... and 2 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 033b4dd into main May 8, 2024
4 of 6 checks passed
@beer-1 beer-1 deleted the feat/add-optional-erc20-support branch May 8, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants