chore: bump proto #153
chore: bump proto #153
Conversation
WalkthroughThis pull request introduces a set of configuration and dependency updates across the repository. The changes include modifying the GitHub Actions spellcheck job to skip an additional file, updating Docker base images, bumping a proto version in the Makefile, and streamlining some application code comments. Additionally, several Go module dependencies and toolchain versions have been upgraded or adjusted, and the protocol buffers configuration has been revised. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant appCreator
participant initiaApp
User->>appCreator: Invoke appExport(...)
Note over appCreator: (Previously: check for homePath)
appCreator->>initiaApp: Instantiate application
appCreator->>initiaApp: Export state & validators
initiaApp-->>appCreator: Export confirmation
appCreator-->>User: Provide export data
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 Gitleaks (8.21.2)proto/buf.yaml8-8: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) ⏰ Context from checks skipped due to timeout of 90000ms (4)
🔇 Additional comments (3)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
go.mod (1)
275-276: Commented Replace Directive for gogo/protobufThe replace directives for
github.com/gogo/protobufhave been commented out on lines 275-276. Verify if this block is meant to be retained for reference or eventually removed. If it is no longer needed, consider cleaning it up to avoid confusion.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (5)
go.sumis excluded by!**/*.sumgo.workis excluded by!**/*.workintegration-tests/go.sumis excluded by!**/*.sumx/evm/types/query.pb.gois excluded by!**/*.pb.gox/evm/types/tx.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (9)
.github/workflows/spellcheck.yml(1 hunks)Dockerfile(1 hunks)Dockerfile.arm64(1 hunks)Makefile(1 hunks)app/app.go(1 hunks)cmd/minitiad/root.go(0 hunks)go.mod(4 hunks)integration-tests/go.mod(2 hunks)proto/buf.yaml(1 hunks)
💤 Files with no reviewable changes (1)
- cmd/minitiad/root.go
✅ Files skipped from review due to trivial changes (3)
- Makefile
- Dockerfile
- app/app.go
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Run test and upload codecov
🔇 Additional comments (7)
Dockerfile.arm64 (1)
1-1: Base Image Update VerificationThe base image on line 1 is updated to
arm64v8/golang:1.23-bullseye, which is consistent with the overall upgrade to Go 1.23 used elsewhere in the project. Please confirm that all build scripts and dependency versions are compatible with this new image.proto/buf.yaml (2)
6-8: Dependency Version Flexibility UpdateThe dependency entries for
buf.build/cosmos/cosmos-proto,buf.build/cosmos/gogo-proto, andbuf.build/googleapis/googleapishave been updated to remove hard-coded commit hashes. This change introduces flexibility in selecting versions, but please verify that downstream code remains compatible with any new versions that the dependency resolver might pull.
11-11: New Dependency AdditionA new dependency
buf.build/protocolbuffers/wellknowntypes:v23.4has been added. Ensure that this version (v23.4) integrates correctly with the protobuf definitions used across the project..github/workflows/spellcheck.yml (1)
16-16: Expanded Skip List for SpellcheckThe addition of
swagger-ui.cssto the skip list on line 16 is appropriate if this file is auto-generated or maintained separately. This change will help reduce noise in the spellcheck results.integration-tests/go.mod (1)
3-5: Go Version and Toolchain UpgradeThe Go version has been updated to
1.23.3and the toolchain togo1.23.5as shown on lines 3 and 5. This aligns the integration tests module with the main project’s configuration. Please double-check that all integration tests run as expected with these new versions.go.mod (2)
3-5: Main Module Go Version and Toolchain UpdateThe main module’s Go version and toolchain have been updated to
1.23.3andgo1.23.5respectively. This ensures consistency across the codebase.
41-45: KV Indexer Dependency BumpThe version for
github.com/initia-labs/kvindexerand its submodules (block,evm-nft,evm-tx, andpair) have been bumped to new pre-release versions. This update appears to follow the required interim changes. Please ensure that all components using these modules have been tested against these new versions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
=======================================
Coverage 57.34% 57.34%
=======================================
Files 113 113
Lines 10629 10629
=======================================
Hits 6095 6095
Misses 3649 3649
Partials 885 885
|
Description
Closes: #XXXX
This PR is interim and should not be tagged since it has dependency on kvindexer's non-tagged commit
I'll make another PR with tagged kvindexer(depend on this merge commit) once this PR merged to main.
I think we can make a tag minievm once another PR I mentioned
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
swagger-ui.cssfrom spell-checking.