feat: json rpc #22
Merged
feat: json rpc #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 31.67% 27.64% -4.04%
==========================================
Files 68 96 +28
Lines 8439 10795 +2356
==========================================
+ Hits 2673 2984 +311
- Misses 5408 7400 +1992
- Partials 358 411 +53
|
whenever ethereum tx is converted into cosmos tx by ConvertEthereumTxToCosmosTx, the value is converted to cosmos fee unit from wei. so when convert the cosmos tx to back the original ethereum tx, we should convert the value back to wei to get original ethereum tx.
djm07073
reviewed
Jun 26, 2024
* feat: new eth apis, refactor: code structures new eth apis - GetStorageAt - GetCode refactor - Restricted the scope of access for each namespace API (instead of accessing the backend directly, now access is through a scoped wrapper) - Also renamed files and repositioned some methods within the backend directory to better reflect their purpose * fix: not implemented txpool api temp disable txpool api because we don't have any implementation * fix: change event type for extract logs * add cap for filters * add filter system and apis * fix comment Co-authored-by: zsystm <[email protected]> * delete unused interfaces and comments * fix varible and function naming * add TODO comments * delete unused functions * add error handling * Set websocket params to prevent timeout * fix: change GetLogsByHeight interface * chore: change variable names from tm to comet * docs: add comments about websocket client params * fix: go.mod and go.work.sum ran the followings for this commit: - go mod tidy - go work sync * update: cometbft dep current version of cometbft which minievm uses have a bug(cometbft/cometbft#3264 (comment)) which makes transaction broadcasting unavailable. --------- Co-authored-by: jason song <[email protected]> Co-authored-by: jasonsong0 <[email protected]>
* change filter system to directly subscribe from indexer * use mutex and pass logs in bulk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.