-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new apis and refactoring #28
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
36c9402
feat: new eth apis, refactor: code structures
zsystm bc5e980
fix: not implemented txpool api
zsystm fc89773
fix: change event type for extract logs
jasonsong0 9e5e17c
add cap for filters
jasonsong0 f9412df
add filter system and apis
jasonsong0 c816b5c
fix comment
jasonsong0 af38813
delete unused interfaces and comments
jasonsong0 35b648d
fix varible and function naming
jasonsong0 37b13b2
add TODO comments
jasonsong0 c0a9e0e
delete unused functions
jasonsong0 bc32eda
add error handling
jasonsong0 4e422f9
Set websocket params to prevent timeout
jasonsong0 6cf230a
fix: change GetLogsByHeight interface
jasonsong0 8d164f2
chore: change variable names from tm to comet
jasonsong0 f493a92
docs: add comments about websocket client params
jasonsong0 88fc512
fix: go.mod and go.work.sum
zsystm c463d44
update: cometbft dep
zsystm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that the target base branch and main branch of this PR are not yet using the specified version of cometBFT. Since there isn't a separate cometBFT bump PR, it would be helpful to add a more detailed explanation of the reason for the bump in this PR description. diff c46468756c01...408dc5262680
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dongsam
I have added the reasoning for bumping up cometBFT version.