Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make json-rpc public by default #37

Closed
wants to merge 1 commit into from
Closed

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Jul 15, 2024

like lcd and rpc, making json-rpc public sounds reasonable to me.
if it is weird or dangerous, please feel free to close this pr :)

@Vritra4 Vritra4 requested a review from beer-1 July 15, 2024 02:29
@Vritra4 Vritra4 self-assigned this Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.05%. Comparing base (fb6e4c8) to head (ecca3c5).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #37   +/-   ##
=======================================
  Coverage   27.05%   27.05%           
=======================================
  Files         100      100           
  Lines       11109    11109           
=======================================
  Hits         3006     3006           
  Misses       7685     7685           
  Partials      418      418           
Files Coverage Δ
jsonrpc/config/config.go 0.00% <ø> (ø)

@beer-1
Copy link
Collaborator

beer-1 commented Jul 16, 2024

If we have no plan to support personal apis, then it should be okay.

@Vritra4
Copy link
Contributor Author

Vritra4 commented Aug 14, 2024

close this: we have no plan i guess :)

@Vritra4 Vritra4 closed this Aug 14, 2024
@Vritra4 Vritra4 deleted the chore/public-jsonrpc branch August 14, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants