Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create db for kvindexer in AppCreator #39

Merged
merged 1 commit into from
Jul 17, 2024
Merged

feat: create db for kvindexer in AppCreator #39

merged 1 commit into from
Jul 17, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Jul 16, 2024

create db for kvindexer inside of AppCreator() in order to be easily customized

NOTE: breaking changes in app.toml due to bumped kvindexer

@Vritra4 Vritra4 requested a review from beer-1 July 16, 2024 06:55
@Vritra4 Vritra4 self-assigned this Jul 16, 2024
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.32%. Comparing base (fb6e4c8) to head (42faa66).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   27.05%   26.32%   -0.74%     
==========================================
  Files         100      100              
  Lines       11109    11183      +74     
==========================================
- Hits         3006     2944      -62     
- Misses       7685     7820     +135     
- Partials      418      419       +1     
Files Coverage Δ
app/test_helpers.go 80.00% <100.00%> (+0.22%) ⬆️
app/app.go 81.77% <66.66%> (ø)
app/encoding.go 44.11% <33.33%> (ø)

... and 9 files with indirect coverage changes

Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 6bf40db into main Jul 17, 2024
6 checks passed
@beer-1 beer-1 deleted the inject-kvdb branch July 17, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants