Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: logger to use local one #47

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: logger to use local one #47

merged 2 commits into from
Aug 20, 2024

Conversation

beer-1
Copy link
Collaborator

@beer-1 beer-1 commented Aug 20, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@beer-1 beer-1 requested a review from a team as a code owner August 20, 2024 07:38
@beer-1 beer-1 self-assigned this Aug 20, 2024
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 26.53%. Comparing base (41c1c3e) to head (f09ef49).
Report is 1 commits behind head on main.

Files Patch % Lines
jsonrpc/backend/tx.go 0.00% 12 Missing ⚠️
jsonrpc/jsonrpc.go 0.00% 10 Missing ⚠️
jsonrpc/backend/block.go 0.00% 4 Missing ⚠️
jsonrpc/backend/backend.go 0.00% 1 Missing ⚠️
jsonrpc/backend/gas.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   26.54%   26.53%   -0.01%     
==========================================
  Files         111      111              
  Lines       11766    11770       +4     
==========================================
  Hits         3123     3123              
- Misses       8198     8202       +4     
  Partials      445      445              
Files Coverage Δ
x/evm/contracts/counter/Counter.go 0.00% <ø> (ø)
x/evm/contracts/erc20/ERC20.go 0.00% <ø> (ø)
x/evm/contracts/erc20_acl/ERC20ACL.go 0.00% <ø> (ø)
x/evm/contracts/erc20_factory/ERC20Factory.go 0.00% <ø> (ø)
x/evm/contracts/erc20_registry/ERC20Registry.go 0.00% <ø> (ø)
x/evm/contracts/ics721_erc721/ICS721ERC721.go 0.00% <ø> (ø)
x/evm/contracts/initia_erc20/InitiaERC20.go 0.00% <ø> (ø)
x/evm/contracts/ownable/Ownable.go 0.00% <ø> (ø)
x/evm/contracts/utils/ERC721Utils.go 0.00% <ø> (ø)
jsonrpc/backend/backend.go 0.00% <0.00%> (ø)
... and 4 more

Copy link
Contributor

@Vritra4 Vritra4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vritra4 Vritra4 merged commit a4d23d2 into main Aug 20, 2024
7 of 8 checks passed
@Vritra4 Vritra4 deleted the fix/logger branch August 20, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants