Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nft transfer #7

Merged
merged 13 commits into from
May 2, 2024
Merged

Feat/nft transfer #7

merged 13 commits into from
May 2, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Apr 30, 2024

No description provided.

@sh-cha sh-cha requested a review from beer-1 April 30, 2024 05:59
@sh-cha sh-cha self-assigned this Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 10.76992% with 2005 lines in your changes are missing coverage. Please review.

Project coverage is 33.41%. Comparing base (a3b3a3f) to head (a8c5c15).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
- Coverage   43.49%   33.41%   -10.09%     
===========================================
  Files          58       66        +8     
  Lines        5267     7449     +2182     
===========================================
+ Hits         2291     2489      +198     
- Misses       2706     4628     +1922     
- Partials      270      332       +62     
Files Coverage Δ
app/app.go 86.68% <100.00%> (+0.71%) ⬆️
app/ibc-hooks/hooks.go 80.00% <100.00%> (+5.80%) ⬆️
x/evm/contracts/counter/Counter.go 0.00% <ø> (ø)
x/evm/contracts/erc20/ERC20.go 0.00% <ø> (ø)
x/evm/contracts/erc20_registry/ERC20Registry.go 0.00% <ø> (ø)
x/evm/keeper/precompiles.go 82.35% <100.00%> (ø)
x/evm/types/address.go 0.00% <ø> (ø)
x/bank/keeper/grpc_query.go 26.28% <0.00%> (ø)
x/evm/client/cli/query.go 0.00% <0.00%> (ø)
x/bank/keeper/keeper.go 48.42% <66.66%> (ø)
... and 16 more

... and 2 files with indirect coverage changes

Copy link
Collaborator

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review my changes before merging.

@sh-cha
Copy link
Contributor Author

sh-cha commented May 2, 2024

LGTM

@sh-cha sh-cha merged commit e4cdc29 into main May 2, 2024
4 of 6 checks passed
@beer-1 beer-1 deleted the feat/nft-transfer branch July 12, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants