Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use posthandler to handle failed tx sequence increment #92

Merged
merged 2 commits into from
Oct 31, 2024

add test

9edaf63
Select commit
Loading
Failed to load commit list.
Merged

fix: do not use posthandler to handle failed tx sequence increment #92

add test
9edaf63
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 30, 2024 in 0s

28.19% (-0.06%) compared to 0ff2791

View this Pull Request on Codecov

28.19% (-0.06%) compared to 0ff2791

Details

Codecov Report

Attention: Patch coverage is 51.16279% with 21 lines in your changes missing coverage. Please review.

Project coverage is 28.19%. Comparing base (0ff2791) to head (9edaf63).

Files with missing lines Patch % Lines
x/evm/keeper/msg_server.go 38.09% 9 Missing and 4 partials ⚠️
x/evm/ante/sequence.go 60.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
- Coverage   28.24%   28.19%   -0.06%     
==========================================
  Files         124      124              
  Lines       13756    13710      -46     
==========================================
- Hits         3886     3866      -20     
+ Misses       9317     9292      -25     
+ Partials      553      552       -1     
Files with missing lines Coverage Δ
app/ante/ante.go 63.33% <100.00%> (ø)
app/ante/sigverify.go 5.21% <ø> (-18.06%) ⬇️
app/posthandler/posthandler.go 100.00% <ø> (ø)
x/evm/ante/sequence.go 60.00% <60.00%> (ø)
x/evm/keeper/msg_server.go 48.91% <38.09%> (-0.52%) ⬇️