Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump deps and prepare upgrade #95

Merged
merged 1 commit into from
Oct 31, 2024
Merged

bump deps and prepare upgrade #95

merged 1 commit into from
Oct 31, 2024

Conversation

beer-1
Copy link
Collaborator

@beer-1 beer-1 commented Oct 31, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • New Features
    • Upgraded to version 0.6.0, enhancing overall functionality and stability.
  • Bug Fixes
    • Improved error handling for contract address collisions during contract creation.
  • Tests
    • Added a new test to validate unique contract address creation with the EVMCreate2 method.

@beer-1 beer-1 self-assigned this Oct 31, 2024
@beer-1 beer-1 requested a review from a team as a code owner October 31, 2024 10:30
Copy link

coderabbitai bot commented Oct 31, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request includes updates to the app/upgrade.go file, changing the upgrade version from "0.5.14" to "0.6.0" and modifying the RegisterUpgradeHandlers function. The parameter name in this function has been updated for clarity, and the error handling logic has been refined. Additionally, the go.mod file has been modified to upgrade the github.com/initia-labs/initia dependency to version v0.6.0 and includes several replace directives for other dependencies. A new test function Test_Create2 has been added to x/evm/keeper/context_test.go to enhance testing coverage.

Changes

File Change Summary
app/upgrade.go - Updated constant upgradeName from "0.5.14" to "0.6.0".
- Renamed parameter vm to versionMap.
- Modified error handling logic in SetUpgradeHandler.
go.mod - Updated dependency github.com/initia-labs/initia from v0.5.6 to v0.6.0.
- Added replace directives for various dependencies.
x/evm/keeper/context_test.go - Added new test function Test_Create2 to test contract address collision error handling.

Possibly related PRs

  • chore: use kvindexr which ignores cache error #94: The changes in go.mod for both the main PR and this PR involve updating dependencies, specifically the github.com/initia-labs/initia dependency in the main PR and github.com/initia-labs/kvindexer in this PR, indicating a related focus on dependency management.

🐰 In the meadow, upgrades bloom,
To version six, we make room.
With handlers clear and tests anew,
Our code hops high, as rabbits do!
Dependencies fresh, we leap with glee,
In this garden of code, we’re wild and free! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@beer-1 beer-1 merged commit 230ecbf into main Oct 31, 2024
6 of 7 checks passed
@beer-1 beer-1 deleted the bump/deps branch October 31, 2024 10:36
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 28.07%. Comparing base (ed359ac) to head (591da6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/upgrade.go 0.00% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   28.05%   28.07%   +0.01%     
==========================================
  Files         126      126              
  Lines       14020    14021       +1     
==========================================
+ Hits         3934     3937       +3     
+ Misses       9532     9531       -1     
+ Partials      554      553       -1     
Files with missing lines Coverage Δ
app/upgrade.go 27.27% <0.00%> (-2.73%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant