bump: CometBFT to update txindex pruning strategy
#84
Conversation
WalkthroughThe pull request includes significant updates to the Changes
Possibly related PRs
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
beer-1
changed the title
txindex pruning strategy
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
go.mod (3)
286-286: Consider upstreaming custom changes for maintainabilityUsing a custom fork can lead to maintenance challenges. If possible, consider contributing your txindex pruning enhancements back to the upstream
github.com/cometbft/cometbftrepository. This will help reduce technical debt and benefit the wider community.
Line range hint
291-291: Monitor pending PRs for module replacementsThe replacement of
github.com/strangelove-ventures/cometbft-clientwithgithub.com/initia-labs/cometbft-clientis temporary until the linked PR is merged. Keep track of the PR status and update the replacement accordingly once it's merged to maintain alignment with the upstream.
Line range hint
294-294: Re-evaluate the gRPC version downgradeYou have downgraded
google.golang.org/grpcto versionv1.65.0due to an issue withcosmos/relayer. Check if the issue has been resolved in newer versions of gRPC to benefit from the latest features, performance improvements, and security patches.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (1)
go.mod(1 hunks)
🔇 Additional comments (2)
go.mod (2)
287-287: Verify compatibility with custom IBC-Go module
You have replaced github.com/cosmos/ibc-go/v8 with github.com/initia-labs/ibc-go/v8. Ensure that this custom version is compatible with your codebase and that any custom changes are thoroughly tested.
Run the following script to check for any potential issues:
✅ Verification successful
Let me gather more information about the specific changes in the custom IBC-Go fork to better assess compatibility.
Let me check one more thing to verify if there are any significant modifications in the custom fork by examining the commit hash.
Based on the gathered information, I can now provide the final response:
Custom IBC-Go fork appears compatible with standard usage patterns
The custom fork maintains standard IBC-Go v8 interfaces as evidenced by:
- All imports in the codebase use standard IBC-Go paths and types
- The fork adds a post-update handler without breaking existing functionality
- Core IBC components (transfer, ICA, hooks) are used in a standard way
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check for usages of the IBC-Go module and verify compatibility.
# List all files importing the IBC-Go module
rg 'github.com/cosmos/ibc-go/v8' --files-with-matches
# Confirm the custom module is correctly referenced
grep -rn 'github.com/initia-labs/ibc-go/v8' go.mod
Length of output: 590
Script:
#!/bin/bash
# Check the differences in imports and usage patterns
rg "github.com/cosmos/ibc-go/v8" -A 2 app/app.go app/modules.go
# Check for any potential breaking changes or custom implementations
rg "github.com/cosmos/ibc-go/v8" -A 2 app/ibc-hooks/
# Check go.sum for version information
grep "github.com/initia-labs/ibc-go/v8" go.sum
Length of output: 5062
Script:
#!/bin/bash
# Get the repository information and commit details
gh repo view github.com/initia-labs/ibc-go --json description,defaultBranch
gh api repos/initia-labs/ibc-go/commits/19c0b4ad450d --jq '.commit.message'
Length of output: 1321
286-286: Ensure the custom CometBFT module includes txindex pruning changes
You have replaced github.com/cometbft/cometbft with a custom fork github.com/initia-labs/cometbft at a specific commit. Verify that this custom module includes the necessary txindex pruning functionality to address the transaction indexing data accumulation issue.
Run the following script to confirm that the txindex pruning changes are present in the custom module:
Description
Previously, we did not prune the
tx.height,tx.hash, orblock.height, even though we set[txindex].retain-heightto a non-zero value. This resulted in the continuous accumulation of transaction indexing data. To prevent the need for state synchronization every few days, we've decided to remove the practice of indefinitely increasing transaction indexing data.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
Summary by CodeRabbit
New Features
github.com/gin-gonic/ginto address a vulnerability.Bug Fixes