Do not reuse the response body when parsing errors #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e5a710f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jacobheric
approved these changes
Nov 25, 2024
Merged
BrunoScheufler
pushed a commit
that referenced
this pull request
Mar 24, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Minor Changes - [#918](#918) [`a305a15`](a305a15) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add support for [Temporal](https://tc39.es/proposal-temporal/) APIs. ```ts inngest.createFunction( { id: "my-fn", }, { event: "test/hello.world", }, async ({ event, step }) => { // sleep with a `Temporal.Duration` await step.sleep("😴", Temporal.Duration.from({ seconds: 10 })); await step.sleep("😴", Temporal.Duration.from({ minutes: 5 })); await step.sleep("😴", Temporal.Duration.from({ hours: 1 })); // sleepUntil using a `Temporal.Instant` or `Temporal.ZonedDateTime` await step.sleepUntil( "😴", Temporal.Instant.from("2025-03-19T12:00:00Z"), ); await step.sleepUntil( "😴", Temporal.ZonedDateTime.from("2025-03-19T12:00[Europe/London]"), ); // sleepUntil also works with relative time const now = Temporal.Instant.from(event.user.createdAtISO); await step.sleepUntil( "😴", now.add(Temporal.Duration.from({ minutes: 30 })), ); }, ); ``` ### Patch Changes - [#745](#745) [`ff01cd2`](ff01cd2) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Fix rare body reuse when parsing failure returns from `inngest.send()` and `step.sendEvent()` - [#916](#916) [`ab835ee`](ab835ee) Thanks [@BrunoScheufler](https://github.com/BrunoScheufler)! - - Connect: Allow supplying Inngest env as environment variable - [#913](#913) [`b090e27`](b090e27) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Export the `version` of the package - [#921](#921) [`374727f`](374727f) Thanks [@BrunoScheufler](https://github.com/BrunoScheufler)! - connect: Include RunID in acks / sdk response Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes some unlucky reuse of the
Responsebody when attempting to parse errors from theinngest.send()response.Checklist
Added a docs PR that references this PRN/A Bug fixRelated