Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3 - Incorrect handling for first comment after function defini… #13

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

inno
Copy link
Owner

@inno inno commented Jun 7, 2024

…tion

* Use ast to detect the last line of the last argument, stop
  iterating once we're past it

…tion

    * Use ast to detect the last line of the last argument, stop
      iterating once we're past it
@inno inno merged commit c79fda8 into main Jun 7, 2024
8 checks passed
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 99.42%. Comparing base (2e95115) to head (dd4d66c).
Report is 1 commits behind head on main.

Files Patch % Lines
simplecli/simplecli.py 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #13      +/-   ##
===========================================
- Coverage   100.00%   99.42%   -0.58%     
===========================================
  Files            2        2              
  Lines          334      345      +11     
  Branches        83       85       +2     
===========================================
+ Hits           334      343       +9     
- Misses           0        1       +1     
- Partials         0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inno inno deleted the 3_first_comment_after_function branch June 7, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant