Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding license file to project #69

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Adding license file to project #69

merged 2 commits into from
Feb 8, 2024

Conversation

snake14
Copy link
Contributor

@snake14 snake14 commented Feb 8, 2024 •
edited
Loading

Description:

Adding license file to project
Jira Issue: PG-3284
Fixes: #68

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

AltamashShaikh
AltamashShaikh approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@AltamashShaikh AltamashShaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@snake14 snake14 merged commit 100426d into 5.x-dev Feb 8, 2024
1 check passed
@snake14 snake14 deleted the pg-3284-add-license-file branch February 8, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AltamashShaikh AltamashShaikh AltamashShaikh approved these changes

Assignees
No one assigned
Labels
Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Licensing
2 participants
@snake14 @AltamashShaikh