Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerize and refactor #1

Merged
merged 14 commits into from
Apr 26, 2024
Merged

Containerize and refactor #1

merged 14 commits into from
Apr 26, 2024

Conversation

ottolote
Copy link
Collaborator

@ottolote ottolote commented Apr 25, 2024

SUMMARY

Containerize the application and refactor some functionality, e.g. config

DETAILS

  • Change config to be based on environment variables (12factor.net/config)
  • Adhere to PEP 8 python style guide
  • Allow for markdown to be anywhere alongside other files, not just in an isolated folder
  • Allow for relative image references to be anywhere, not just in an isolated image folder
  • Containerize it (Dockerfile, build pipeline, docs)
  • Add configurable .confluenceignore file

CHANGE LIST

  • Run formatter
  • Rename variables and files
  • Refactor publisher, adhere to PEP 8
  • Move parser to config, read config from environment variables, enable HTTPS cert verification, remove yaml dependency, add sleep to allow for delete to fully complete
  • Add MARKDOWN_TARGET as specified folder, allowing any markdown + images to be supported anywhere in the folder
  • Add Dockerfile
  • Add README.md, move markdown into markdownsample folder
  • Add publish container github action and remove old action
  • Change Dockerfile from alpine to slim (to include /bin/bash)
  • Change CONFLUENCE_SPACE to CONFLUENCE_SPACE_ID
  • Strip whitespace
  • Add support for a .confluenceignore file w/ config options and ignored files in markdownsample folder
  • Add tag from git describe, remove unused step

@ottolote ottolote requested a review from sshjelle April 25, 2024 12:50
Copy link
Collaborator

@sshjelle sshjelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@ottolote ottolote merged commit 6e1a542 into main Apr 26, 2024
1 check passed
@ottolote ottolote deleted the ol/containerize branch April 26, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants