Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebSockets communication capabilities #9

Merged
merged 14 commits into from
Jan 5, 2024

Conversation

leandropineda
Copy link
Member

@leandropineda leandropineda commented Dec 20, 2023

🗒️ Description

Adds support for subscribing and consuming messages though the WebSocket interface. Note that even though it's not documented, this PR emulates how the MiR Web Interface interacts with the robot, and thus it should be considered experimental.

Additional comments:

  • To support both REST and WS mechanisms, I changed the configuration file and refactored MiR100ConfigModel accordingly.
  • Also added the missing my_fleet.example.yaml configuration file.
  • This PR also bumps the edge-sdk-python package version to support publishing system stats: Add support for system values reporting edge-sdk-python#33

📺 Demo

N/A

Copy link
Member

@b-Tomas b-Tomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, @leandropineda!

@elvioaruta
Copy link
Member

If we wait for this PR: inorbit-ai/edge-sdk-python#33 we can implement the publish_system_stats for the CPU :)

elvio.aruta98 added 3 commits January 5, 2024 11:12
…s, implemented get_cpu_usage, implemented get_disk_usage, implemented get_memory_usage
@elvioaruta
Copy link
Member

elvioaruta commented Jan 5, 2024

@leandropineda Added 3 commits with system stats publishing, also I have resolved your TODO about re using the function to extract status values from the WS, I'll remove my self as a reviewer and I let you review this part of the MR

@elvioaruta elvioaruta removed their request for review January 5, 2024 14:16
@elvioaruta elvioaruta assigned elvioaruta and unassigned elvioaruta Jan 5, 2024
@elvioaruta elvioaruta self-requested a review January 5, 2024 14:22
@elvioaruta
Copy link
Member

@leandropineda after fixing jobs and tests, now it's ready for review :)

@elvioaruta elvioaruta marked this pull request as ready for review January 5, 2024 15:06
@leandropineda leandropineda merged commit f4410c2 into inorbit-ai:main Jan 5, 2024
11 checks passed
@leandropineda leandropineda deleted the mir_ws_cpu_usage branch January 5, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants