First version of the package in ROS Noetic #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandropineda
approved these changes
May 27, 2022
massrobotics_amr_sender/sample/massrobotics_amr_sender_rosbag_launch.launch
Show resolved
Hide resolved
|
Done! Thanks Lean for checking that, I've updated all the references to ROS1. |
adamantivm
approved these changes
May 30, 2022
There was a problem hiding this comment.
I think this is awesome @FlorGrosso ! I would go ahead and merge. We can then test it and fix as we find problems.
If you want to be extra nice, you can create issues for the remaining items (tests and publishing the package)
|
Thanks. @adamantivm ! I've created #26 and #27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a version of the package in ROS 1 Noetic, Python 3. It includes:
massrobotics_amr_senderpackage which can be installed from source.TODOs: