Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLT-9262: Fix missing minUTXO problem with 0.0.5 #172

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

hrajchert
Copy link
Collaborator

@hrajchert hrajchert commented Jan 15, 2024

This PR adds a sensible default of 3Ada as minUTXO when the runtime version is 0.0.5 and it leaves it empty for other versions

fixes #169

Summary by CodeRabbit

  • New Features
    • Added a version check capability to the REST client interface.
  • Improvements
    • Enhanced the contract creation transaction process to support multiple runtime versions.
  • Refactor
    • Removed unused imports to streamline the codebase.

Copy link
Contributor

coderabbitai bot commented Jan 15, 2024

Walkthrough

The recent update streamlines the client's REST interface by removing dependencies on functional programming libraries and a specific domain library. It also introduces a new version method to the RestClient interface, allowing for version checks, and updates the buildCreateContractTx method to accommodate multiple runtime versions, reflecting a move towards a more versatile and simplified codebase.

Changes

File Path Change Summary
.../client/rest/src/index.ts Removed fp-ts and @marlowe.io imports, added version method, updated buildCreateContractTx for runtime version handling.

🐇✨
In the realm of code where the data streams flow,
A rabbit hopped in, with changes in tow.
Out with the old libs, a new version's cheer,
To the REST client's future, we hop without fear! 🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between db2f342 and 6ede73c.
Files selected for processing (1)
  • packages/runtime/client/rest/src/index.ts (5 hunks)
Additional comments: 5
packages/runtime/client/rest/src/index.ts (5)
  • 42-42: The import of RuntimeVersion is correctly added to support the new functionality.
  • 82-82: The addition of the version method to the RestClient interface is consistent with the PR objectives to handle different runtime versions.
  • 281-284: Caching the runtime version as it's not expected to change during the lifetime of the RestClient is a reasonable approach to avoid unnecessary calls.
  • 310-316: The logic to set a default minimum UTXO value of 3 Ada for runtime version 0.0.5 is implemented as described in the PR objectives.
  • 322-324: The handling of the minUTxODeposit within the postContractsRequest object is correct and follows the intended logic for different runtime versions.

@hrajchert hrajchert merged commit 0acd659 into main Jan 15, 2024
2 of 3 checks passed
@hrajchert hrajchert deleted the hrajchert/plt-9262-minutxo branch January 15, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PLT-9262: Make minUTXO required in restClient
2 participants