-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLT-9262: Fix missing minUTXO problem with 0.0.5 #172
Conversation
WalkthroughThe recent update streamlines the client's REST interface by removing dependencies on functional programming libraries and a specific domain library. It also introduces a new Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/runtime/client/rest/src/index.ts (5 hunks)
Additional comments: 5
packages/runtime/client/rest/src/index.ts (5)
- 42-42: The import of
RuntimeVersion
is correctly added to support the new functionality.- 82-82: The addition of the
version
method to theRestClient
interface is consistent with the PR objectives to handle different runtime versions.- 281-284: Caching the runtime version as it's not expected to change during the lifetime of the RestClient is a reasonable approach to avoid unnecessary calls.
- 310-316: The logic to set a default minimum UTXO value of 3 Ada for runtime version 0.0.5 is implemented as described in the PR objectives.
- 322-324: The handling of the
minUTxODeposit
within thepostContractsRequest
object is correct and follows the intended logic for different runtime versions.
This PR adds a sensible default of 3Ada as minUTXO when the runtime version is 0.0.5 and it leaves it empty for other versions
fixes #169
Summary by CodeRabbit